Fix bounds/fitBounds not working on first display. #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2022
|
I had #409 when I updated to v3.0.0. I tested this pr and the issue was gone. |
|
LGTM I did NOT have #409 but have tested this code in my app and it looks good! |
JaffaKetchup
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Haven't tested (sorry, still quite busy rn), submitting approval on behalf of @moonag :)
|
@ibrierley Feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fitbounds doesn't work on initial frame when its on a fast device as it tries to display before it can get a size of the device, due to the nature of a layout builder. This tries to rectify one of the checks to toggle when a size is available for bounds checking.
Please test this thoroughly on mobile and on web. Pay especial attention for first frame adjustment flicker that could be annoying, checking that bounds in MapOptions behaves correctly.